Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get_building_lab_zones_list() #1463

Open
JacksonJ-KC opened this issue Aug 1, 2024 · 1 comment
Open

get_building_lab_zones_list() #1463

JacksonJ-KC opened this issue Aug 1, 2024 · 1 comment
Assignees

Comments

@JacksonJ-KC
Copy link
Collaborator

The function only considers spaces as lab if space.function is LABORATORY. Should this also consider spaces labs if lighting_space_type is LABORATORY_EXCEPT_IN_OR_AS_A_CLASSROOM?

@JacksonJ-KC JacksonJ-KC added question Further information is requested section23 labels Aug 1, 2024
@JacksonJ-KC JacksonJ-KC self-assigned this Aug 1, 2024
@claperle
Copy link
Collaborator

claperle commented Aug 6, 2024

@JacksonJ-KC I agree with your recommended change. I think the function should check to see if either are defined. And use whichever are defined. If they conflict then we can't determine whether it's a lab.

@JacksonJ-KC JacksonJ-KC removed the question Further information is requested label Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants