Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rule 23-1 logic does not align with Rule Description #1429

Open
JacksonJ-KC opened this issue Jul 29, 2024 · 3 comments · May be fixed by #1434
Open

Rule 23-1 logic does not align with Rule Description #1429

JacksonJ-KC opened this issue Jul 29, 2024 · 3 comments · May be fixed by #1434
Assignees
@weilixu @claperle @KarenWGard @JacksonJ-KC
Labels
bug Something isn't working section23

Comments

@JacksonJ-KC
Copy link
Collaborator

Rule description:

System 2 and 4 - Electric air-source heat pumps shall be modeled with electric auxiliary heat and an outdoor air thermostat. The systems shall be controlled to energize auxiliary heat only when the outdoor air temperature is less than 40°F. The air-source heat pump shall be modeled to continue to operate while auxiliary heat is energized.

The rule logic does not include any logic pertaining to auxiliary heat. Data elements heatpump_auxilliary_heat_type, and heatpump_auxilliary_heat_high_shutoff_temperature are not used.
@JacksonJ-KC JacksonJ-KC added bug Something isn't working section23 labels Jul 29, 2024
@KarenWGard
Copy link
Collaborator

good catch. Updated the logic

@JacksonJ-KC
Copy link
Collaborator Author

Can you please point to the update?

@KarenWGard KarenWGard linked a pull request Jul 30, 2024 that will close this issue
Open
@KarenWGard
Copy link
Collaborator

Can you please point to the update?

created new pull request

@JacksonJ-KC JacksonJ-KC linked a pull request Aug 5, 2024 that will close this issue
Update Rule23-1.md #1434
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@weilixu weilixu

@claperle claperle

@KarenWGard KarenWGard

@JacksonJ-KC JacksonJ-KC

Labels
bug Something isn't working section23
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update Rule23-1.md pnnl/ruleset-checking-tool
4 participants
@weilixu @claperle @KarenWGard @JacksonJ-KC