Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non-unique ids in Theming Controlpanel #1242

Open
me-kell opened this issue Nov 21, 2022 · 1 comment
Open

Non-unique ids in Theming Controlpanel #1242

me-kell opened this issue Nov 21, 2022 · 1 comment

Comments

@me-kell
Copy link

me-kell commented Nov 21, 2022

The "Theming Controlpanel" (aka. "Theme settings") has two levels of nav-elements with non-unique ids.

    1. level: autotoc-item-autotoc-0, autotoc-item-autotoc-1
    1. level: autotoc-item-autotoc-0, autotoc-item-autotoc-1, autotoc-item-autotoc-2

The given anchors are also non-unique (see href attributes). It is not possible to properly access the elements via a url with anchor.

I'd suggest to change the 2. level ids to something like autotoc-item-autotoc-1-0, autotoc-item-autotoc-1-1, autotoc-item-autotoc-1-2

In which repository should I post an issue?

For more details and an image see this issue and the comments.

Plone - Theme settings

@me-kell
Copy link
Author

me-kell commented Nov 21, 2022

Actually both following problems should be also taken into account:

  1. Requesting /@@theming-controlpanel#autotoc-item-autotoc-2 doesn't position the form in "Custom Styles" as expected.
  2. Wenn the "Save"-Button in "Custom Styles" is pressed, the form is requested again and the page goes to "Themes". This requires the user to click "Advanced setting" and "Custom Styles" again every time it saves it.

2022-11-21 14_53_24-demo plone org — Mozilla Firefox

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

No branches or pull requests

1 participant