Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing aditional mcginty/snow test vectors results in a failure #43

Open
quapka opened this issue Jun 23, 2021 · 1 comment
Open

Testing aditional mcginty/snow test vectors results in a failure #43

quapka opened this issue Jun 23, 2021 · 1 comment

Comments

@quapka
Copy link

quapka commented Jun 23, 2021

The Rust version of Noise protocol snow contains additional test vectors. I've pulled them in and simply loaded as the other test vector files (the new ones are one layer deeper in the JSON file behind "vectors" key, I've saved the list directly).

Previously, there were 104 and now there are 408. pytest gave me 304 failures. This suggests some general problem, but the things I've checked so far (e.g. the structure of the test vectors, their keys etc.) look similar between the old snow test vectors and the new ones.

I'm going to take a deeper look.

@quapka
Copy link
Author

quapka commented Jun 23, 2021

An attempt to analyze the errors a bit more:

--> pytest | grep '^E' | sort | uniq -c
     40 E               noise.exceptions.NoiseProtocolNameError: Unknown pattern in Noise Protocol name, given I, known N K X NN KN NK KK NX KX XN IN XK IK XX IX
    120 E           noise.exceptions.NoisePSKError: No PSKs provided
     64 E               ValueError: Unknown pattern modifier 1
     16 E               ValueError: Unknown pattern modifier 1K
     16 E               ValueError: Unknown pattern modifier 1K1
     16 E               ValueError: Unknown pattern modifier 1N
     16 E               ValueError: Unknown pattern modifier 1X
     16 E               ValueError: Unknown pattern modifier 1X1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant