pkp/pkp-lib#10506 user group to use eloquent model #4526
Conversation
Hafsa-Naeem
force-pushed
the
ojs_i10506_UserGroup_to_Use_Eloquent_Model
branch
from
ba596b3
to
0a46028
Compare
|
@Hafsa-Naeem, this won't trigger tests. The update of submodule should be the last commit with the message: All branches in submodule should have the same name: https://docs.pkp.sfu.ca/dev/testing/en/continuous-integration#tests-for-pull-requests |
There was a problem hiding this comment.
Thanks, @Hafsa-Naeem! I left minor comments. Submodule updates require specific commit message and this commit should be last. I. think you can reset the last commit and divide it into 2 separate with the last one to include submodule updates to the shared library, ui library and plugins
| $contextId = $request->getContext()->getId(); | ||
|
|
||
| $userGroups = UserGroup::withContextIds($contextId) | ||
| ->whereHas('userGroupStages', function ($query) use ($stageId) { |
There was a problem hiding this comment.
I see that you already created helper in the Repository:
PKP\userGroup\Repository::getUserGroupsByStage()
The second option is just use the scope, that is also already created:
UserGroup::withContextIds([$contextId])->withStageIds([$stageId]);| ); | ||
| $contextId = $request->getContext()->getId(); | ||
|
|
||
| $userGroups = UserGroup::withContextIds($contextId) |
There was a problem hiding this comment.
UserGroup::withContextIds([$contextId])
| ->filterByContextIds([$context->getId()]) | ||
| ->getMany(); | ||
| $contextId = $request->getContext()->getId(); | ||
| $userGroups = UserGroup::withContextIds($contextId)->get(); |
There was a problem hiding this comment.
UserGroup::withContextIds([$contextId])
No description provided.