Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Empty completeness for simple PICA record #482

Open
nichtich opened this issue May 30, 2024 · 4 comments
Open

Empty completeness for simple PICA record #482

nichtich opened this issue May 30, 2024 · 4 comments
Assignees
Labels
bug partner:vzg Feature request from VZG
Milestone

Comments

@nichtich
Copy link
Collaborator

Given a single PICA+ record (here in PICA Plain syntax in pica.pp, convert to pica.dat with picadata -t norm pica.pp > pica.dat):

003@ $012345X
021A $aEin Buch$hzum Lesen

And configuration

SCHEMA=PICA
CATALOGUE=K10plus
NAME=pica-test
MASK=pica.dat

Completeness result is zero records (validation works).

@nichtich nichtich added bug partner:vzg Feature request from VZG labels May 30, 2024
@pkiraly
Copy link
Owner

pkiraly commented May 30, 2024

Could you try with TYPE_PARAMS="--marcFormat PICA_PLAIN"? (BTW: We should rename marcFormat to inputFormat or serializationFormat)

@pkiraly pkiraly self-assigned this May 31, 2024
@pkiraly
Copy link
Owner

pkiraly commented May 31, 2024

Empty line is a delimiter between records

@pkiraly
Copy link
Owner

pkiraly commented Jun 14, 2024

Here the problem is that the tool expect the record to have 002@ field, that contains the type of the record. This snippet did not have it, and it throws an exception. I fix the code to handle this situation.

@pkiraly pkiraly added this to PICA Jun 14, 2024
@pkiraly pkiraly added this to the PICA: 1.3 milestone Jun 14, 2024
@pkiraly
Copy link
Owner

pkiraly commented Jun 14, 2024

It is testable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug partner:vzg Feature request from VZG
Projects
Status: 👀 In review
Development

No branches or pull requests

2 participants