Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document maintenance workflow #16

Open
thesamesam opened this issue Oct 28, 2023 · 1 comment
Open

Document maintenance workflow #16

thesamesam opened this issue Oct 28, 2023 · 1 comment

Comments

@thesamesam
Copy link
Member

We should document how to update the action, like:

  • what npm invocations are needed (we may want a Docker container given node seems to move slow/fast)
  • need to push to the v1 branch too
@radhermit
Copy link
Contributor

radhermit commented Nov 7, 2023

I purposely didn't use a docker container because nodejs-based Github actions were (and probably still are but perhaps to a lesser extent) much faster at startup and more importantly it allows more control and internal handling over external actions like caching.

However, I can understand the reasoning behind wanting to move that way if the remaining maintainers aren't overly familiar with node (and/or javascript) and don't want the additional maintenance burden but doing so could lose some auto-handled functionality that the nodejs approach allows.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants