Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Version style in the manifest.properties #9

Open
siavashsoleymani opened this issue Oct 19, 2019 · 1 comment
Open

Version style in the manifest.properties #9

siavashsoleymani opened this issue Oct 19, 2019 · 1 comment
Labels
good first issue Good for newcomers

Comments

@siavashsoleymani
Copy link
Contributor

when version in the manifest are the integer number ganjex discovers and contain the service properly but when i put my version something like 1.0.0 that is not an integer ganjex hang up and wont call the hook methods without announcing any exceptions
@isahekmat
Copy link
Member

It's good to print a log when version is not an integer

@isahekmat isahekmat added the good first issue Good for newcomers label Oct 20, 2019
@siavashsoleymani siavashsoleymani mentioned this issue Oct 27, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@isahekmat @siavashsoleymani