-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
store/copr: remove useless ticker for performance #57558
Conversation
Signed-off-by: crazycs520 <crazycs520@gmail.com>
Hi @crazycs520. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #57558 +/- ##
================================================
+ Coverage 72.8166% 73.4613% +0.6447%
================================================
Files 1676 1676
Lines 463603 463630 +27
================================================
+ Hits 337580 340589 +3009
+ Misses 105179 102293 -2886
+ Partials 20844 20748 -96
Flags with carried forward coverage won't be shown. Click here to find out more.
|
/retest-required |
@crazycs520: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tiancaiamao, zyguan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
What problem does this PR solve?
Issue Number: ref #57580
Problem Summary: remove useless ticker for performance
What changed and how does it work?
This pr removes this useless ticker. In current implementation, if the SQL is been killed, then
ctx.Done
will work, so no need the ticker.And remove it is for performance, following is the sysbench oltp_index_scan test, and the range size is 2:
The example query is like this:
Which Plan is:
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.