Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix download using spine information from window.bData #71

Open
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

ahxxm
Copy link

@ahxxm ahxxm commented May 2, 2024

This is similar to my another PR for the new format, the branch is based on #59

audiobooks work just fine with command odmpy libby --ebooks --direct --chapters --merge

for epub books command is the same, and I picked a small one to test locally,

  • it can generate an EPUB correctly with ToC, text styles like bold and italic are preserved(since they are from base64-encoded HTML?)
  • images are also saved, but they didn't exist in bData anymore, I'm not 100% satisfied with the way they are downloaded. e.g. when image src is ../Images/cover.jpg, it can still be downloaded, but need a fix on HTML to display, instead of preserving the origin file hierarchy
  • CSS is downloaded similarly

There are 2 commits trying to make CI happy, but apprently CI isn't that easy to please: linter passed, tests hardcoded the outdated openbook.json and should be fixed as well

@ahxxm ahxxm force-pushed the fix-spine branch 2 times, most recently from 98d689d to b8b4f4f Compare May 2, 2024 06:54
@ahxxm
Copy link
Author

ahxxm commented May 2, 2024

@ping I spent some time to understand mocks but did't make meaningful progress, it would be great if you can help

@stenou stenou mentioned this pull request May 8, 2024
@jahlborn jahlborn mentioned this pull request May 8, 2024
@bckelly1
Copy link

I was trying to figure out why this doesn't work. I think the spine content changed:
"spine": [{"path":"_d/record_access_violation"}]
Looks like they changed the API again.

@ahxxm
Copy link
Author

ahxxm commented Jun 9, 2024

I was trying to figure out why this doesn't work. I think the spine content changed: "spine": [{"path":"_d/record_access_violation"}] Looks like they changed the API again.

yeah, it's bad, please don't use this branch now, the path looks surveillant

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants