-
-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix download using spine information from window.bData #71
base: master
Are you sure you want to change the base?
Conversation
98d689d
to
b8b4f4f
Compare
@ping I spent some time to understand mocks but did't make meaningful progress, it would be great if you can help |
I was trying to figure out why this doesn't work. I think the spine content changed: |
yeah, it's bad, please don't use this branch now, the path looks surveillant |
This is similar to my another PR for the new format, the branch is based on #59
audiobooks work just fine with command
odmpy libby --ebooks --direct --chapters --merge
for epub books command is the same, and I picked a small one to test locally,
bData
anymore, I'm not 100% satisfied with the way they are downloaded. e.g. when image src is../Images/cover.jpg
, it can still be downloaded, but need a fix on HTML to display, instead of preserving the origin file hierarchyThere are 2 commits trying to make CI happy, but apprently CI isn't that easy to please: linter passed, tests hardcoded the outdated
openbook.json
and should be fixed as well