-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
883 raw annotated annotation paragraph a block looks bogus #888
883 raw annotated annotation paragraph a block looks bogus #888
Conversation
This sounds good to me. |
There is one test that is not passing MicTextualMicrodownExporterTest
|
paragraph: [ super visitAnnotated: anAnnotated ] | ||
| string textualExporter | | ||
string := ''. | ||
textualExporter := MicTextualMicrodownExporter new. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pourquoi est ce que tu recrees une instance de la meme classe ? car tu pourrais utiliser self.
Est ce que c'est parce que tu veux jeter le contenu?
La variable string me semble pas etre utilisee.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pour le builder textWithBracket: j'ai besoin d'un String comme paramétre
Comme je n'avait que les enfants de anAnnotated, j'ai utilisé un nouveaux MicTextualMicrodownExporter et je l'ai fait visité tout les enfants afin de produire le String.
Le probléme d'utiliser self comme visiteur des enfants de anAnnotated, et qu'il va ajouter automatiquement dans son stream le contenu de ce qu'il va visiter, sans ajouter le charater '>' au début
Pour la variable String, j'ai oublié de la supprimer
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok je comprends maintenant je me demandais si cela marchait avec plusieurs lignes.
J'imagine que tu as des tests.
Issue #883
I don't know if it's the good way to do, but i don't now how to do with a blockClosure in paragraph of rawAnnotated:paragraph: cause I need to cut the linefeed of the String