Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate IBOM on Safari not working #13

Open
peauters opened this issue Apr 22, 2021 · 2 comments
Open

Investigate IBOM on Safari not working #13

peauters opened this issue Apr 22, 2021 · 2 comments

Comments

@peauters
Copy link

No description provided.

@DrMagPie
Copy link

DrMagPie commented Jun 4, 2021

Hi @pierrechevalier83,

I have encountered issue of iBOM not working for any browser.
issue lies in this regex check on lines 3020 - 3021

  document.getElementById("github-link").innerHTML = "InteractiveHtmlBom " +
    /^v\d+\.\d+/.exec(pcbdata.ibom_version)[0];
}

problem is that pcbdata.ibom_version is "ferris_release_4\n"
but regex expects it to be something like this "v2.3-50-g53ae\n"

so could you please fix it :)

@pierrechevalier83
Copy link
Owner

Thanks @DrMagPie, this is a very helpful observation. Reading the generate_ibom_html code, I can see that some of the code assumes it is run from their own github repo and tries to pull metadata from git. This fails in the way I use it as I am using their repo as a submodule. I think a fix may be to modify the script upstream to allow overriding the version with a command line argument. Will discuss it upstream.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants