Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for iCloud Drive objects throwing str/type/repr errors, fix for #464 #465

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ebob9
Copy link

@ebob9 ebob9 commented Nov 12, 2024

Proposed change

Fix for issue #464

When working with iCloud Drive objects, the str/type/repr functions throw errors. This apparently is due to the "rf" string complexities. I was able to resolve this by replacing "rf" string line in pyicloud with concatenated standard and "f" strings.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New service (thank you!)
  • New feature (which adds functionality to an existing service)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests
  • Documentation or code sample

Example of code:

# create a DriveNode object, and issue a type request.
# assume authenticated api object..
test1 = api.drive.root
print(type(test1))

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

  • Documentation added/updated to README

@ebob9 ebob9 changed the title Fix for picklepete/pyicloud#464 Fix for iCloud Drive objects throwing str/type/repr errors, fix for #464 Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Working with drive objects throws "TypeError: unsupported format string passed to type.__format__"
1 participant