-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changing configure flags for pie build
does not result in a full rebuild
#93
Comments
Yep this is a reasonable improvement we could make - I do think we should clean first. This would only be observable if you are rebuilding an already downloaded version (e.g. |
Hmm, I think I was wrong here about what you're trying to do, @TimWolla...? I'm trying out PR #130 and noticed it NEVER actually cleans in practice; and with some actual checking, it seems Composer does actually replace the whole ext path, even if installing exactly the same version. I used the example ext, and made a PHP file <?php
example_pie_extension_test();
Subsequently re-installing the same ext with only a changed configure parameter, e.g.:
Are you still able to reproduce this issue, @TimWolla ? 🤔 |
Yes. I'm on commit 75dbc22. As mentioned in the initial message: It might be a bug in the configure script / resulting Makefile. In my case it's a flag to the linker that changes, but I believe it should be equally reproducible with any other compiler flag that does not result in a source code change, for example optimization flags. Log
|
Working with #83:
I'm not sure if my Makefile / configure script is incorrectly written and does not properly handle the build dependencies, but given the fact that
pie
always runs bothphpize
and./configure
for each build, it would probably make sense to run the equivalent ofgit clean -fdx
in the build directory to ensure that the build is internally consistent. Even if the build infrastructure is actually faulty, this could otherwise lead to hard-to-debug issues.The text was updated successfully, but these errors were encountered: