Skip to content
This repository has been archived by the owner on Oct 4, 2020. It is now read-only.

Add per-channel darkness option #46

Open
SamWhited opened this issue Jun 2, 2015 · 1 comment
Open

Add per-channel darkness option #46

SamWhited opened this issue Jun 2, 2015 · 1 comment

Comments

@SamWhited
Copy link
Member

Add an option for setting the black level per channel (libraw: user_cblack).

I've made this a separate issue from the normal options issue because we need to experiment with it and decide on an API. My first thought was that if you set darkness to a 3 or 4 tuple it knows to do it per channel, otherwise do it globally. However, the options may stack (addative?) and if so we might want to support both (or we could just leave that up to the user and do it the original way... if they want extra black per channel they can just add some ammount per channel, it's not that hard).

Thoughts? /cc @campaul

TL;DR —

raw.options.darkness = (1, 2, 3, 4)
# or raw.options.darkness = 1, but we can't do both together

or

raw.options.darkness = 1
raw.options.channel_darkness = (1, 2, 3, 4) # Why didn't we just do (2, 3, 4, 5) (if that's actually how this works)?

Possibly blocking on #51 depending on what we decide to do.

@SamWhited
Copy link
Member Author

I double checked this today: user_cblack is a per-channel adjustment to the normal black level (it's relative, not absolute, so it will stack ontop of the default value).

SamWhited added a commit to SamWhited/rawkit that referenced this issue Jun 13, 2015
Fixes photoshell#46

Change the name of the darkness option
Remove pre-commit hook that won't play nicely with namedtuples
@SamWhited SamWhited modified the milestones: v1.0.0, v0.5.0 Jun 28, 2015
SamWhited added a commit to SamWhited/rawkit that referenced this issue Jul 5, 2015
Fixes photoshell#46

Change the name of the darkness option
Remove pre-commit hook that won't play nicely with namedtuples
SamWhited added a commit to SamWhited/rawkit that referenced this issue Jul 5, 2015
Fixes photoshell#46

Change the name of the darkness option
Remove pre-commit hook that won't play nicely with namedtuples
SamWhited added a commit to SamWhited/rawkit that referenced this issue Jul 5, 2015
Fixes photoshell#46

Change the name of the darkness option to `sensel_threshold'
SamWhited added a commit to SamWhited/rawkit that referenced this issue Jul 17, 2015
Fixes photoshell#46

Change the name of the darkness option to `sensel_threshold'
@SamWhited SamWhited modified the milestones: v0.6.0, v0.5.0 Aug 13, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant