Skip to content
This repository has been archived by the owner on Oct 4, 2020. It is now read-only.

Invalid raw.data.contents.color.rgb_cam? #141

Open
pkorus opened this issue Aug 15, 2018 · 1 comment
Open

Invalid raw.data.contents.color.rgb_cam? #141

pkorus opened this issue Aug 15, 2018 · 1 comment

Comments

@pkorus
Copy link

pkorus commented Aug 15, 2018

I'm writing my own RAW development procedure, and I encountered a potential problem with the sRGB conversion matrix as reported by rawkit. Specifically, the array returned by raw.data.contents.color.rgb_cam is:

[[ 1.82691061 -0.65497452 -0.17193617]
 [ 0.         -0.00683982  1.33216381]
 [-0.32532394  0.          0.06269717]
 [-0.40055895  1.33786178  0.        ]]

And it should be (as correctly reported by a different ctypes-based libraw wrapper).

[[ 1.8269106  -0.6549745  -0.17193617  0.        ]
 [-0.00683982  1.3321638  -0.32532394  0.        ]
 [ 0.06269717 -0.40055895  1.3378618   0.        ]]

It would appear that the array dimensions are swapped somewhere.

@campaul
Copy link
Member

campaul commented Sep 18, 2018

I'm not surprised, there are lots of features we haven't fully tested. I'm not actively working on this library anymore, but if you open a PR with a fix we'll merge it.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants