Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

why do we need to infer the trades from orders? the log already has them #31

Open
ssh352 opened this issue Jan 13, 2020 · 1 comment
Open

Comments

@ssh352
Copy link

ssh352 commented Jan 13, 2020

First, thank you for such a useful package! I am not familiar to bitstamp data so have this question:

I assume extdata/2015-05-01.log.xz is the raw market data recording, it already has trades in it. Why does the package spend time on inferring the trades from orders?

Screen Shot 2020-01-13 at 3 06 43 PM

the inferred trades count is 482

Screen Shot 2020-01-13 at 3 06 15 PM

parse.sh explicitly filters trades and generates the orders.csv

Screen Shot 2020-01-13 at 3 05 58 PM

the log has 575 trades, which is different from number of inferred trades.

the individual orders and trades are usually directly provided by exchanges, so why does the package spend time on inferring trades from orders?

@petr-fedorov
Copy link
Contributor

For not all matched orders produce trades. There are so-called 'self-trades' which can be inferred from live_orders data but will not appear among trades due to sefl-trade prevention by Bitstamp
Also have a look at this discussion

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants