Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package does not understand buildMicroDownUsing: builder withComment: aString #15916

Closed
Ducasse opened this issue Jan 4, 2024 · 9 comments
Closed
Assignees
Labels
Project: Calypso Project: Documentation Documentation/Welcome/... To fix before release Issure to fix before the upcoming Pharo release Version: Pharo 12
Milestone

Comments

@Ducasse
Copy link
Member

Ducasse commented Jan 4, 2024

So we lost this method from P11.

@Ducasse Ducasse added this to the 12.0.0 milestone Jan 4, 2024
@Ducasse
Copy link
Member Author

Ducasse commented Jan 4, 2024

I do not really get this

ClyPackageRichTextCommentEditorToolMorph >> renderComment: aString of: aClassOrPackage 
	"The actual implementation is moved to BeautifulComments - basically to allow Testing"
	
	^ BeautifulComments renderComment: aString of: aClassOrPackage

@Ducasse
Copy link
Member Author

Ducasse commented Jan 4, 2024

Capture 2024-01-04 at 20 11 08

@hernanmd
Copy link
Member

I fixed it here pillar-markup/Microdown#675
But tests are failing and then 99.9% of changes are formatting.

Should I open another issue in Microdown to fix the failing tests?

@Ducasse
Copy link
Member Author

Ducasse commented Jan 18, 2024

Thanks hernan. I'm flooded by work. So I do not know.
I will check for the tests before integrating this change.

@hernanmd
Copy link
Member

No problem Stef. I just opened an issue here: pillar-markup/Microdown#681
So it would be necessary to fix Microdown issues.

@Ducasse
Copy link
Member Author

Ducasse commented Feb 24, 2024

Ok I released a version of microdown for P12 and it should fix this problem. It is V2.5.0. Now we should merge it into pharo12.
But I want to do it with people around and not when many are on vacation.

@Ducasse Ducasse added the To fix before release Issure to fix before the upcoming Pharo release label Feb 24, 2024
@Ducasse
Copy link
Member Author

Ducasse commented Mar 12, 2024

I merge V2.5.0 of microdown in the microdown branch Pharo12 so this bug should be fixed.

@Ducasse Ducasse assigned Ducasse and unassigned hernanmd Mar 12, 2024
@estebanlm
Copy link
Member

I confirm this is done

@Ducasse
Copy link
Member Author

Ducasse commented Mar 14, 2024

nice to know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Project: Calypso Project: Documentation Documentation/Welcome/... To fix before release Issure to fix before the upcoming Pharo release Version: Pharo 12
Projects
None yet
Development

No branches or pull requests

3 participants