Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance test coverage for get_vars_query(), assert_valid_queries(), assert_db_requirements(), validate_query(), basket_select() #2579

Open
5 tasks
manciniedoardo opened this issue Nov 27, 2024 · 0 comments
Labels

Comments

@manciniedoardo
Copy link
Collaborator

Background Information

It would be great to get {admiral}'s test coverage to 100%. However, this should not come at the expense of development time/effort from {admiral} core developers. As such, I have made a set of issues tagged "Unit Tests" (such as this one for get_vars_query(), assert_valid_queries(), assert_db_requirements(), validate_query() and basket_select()) where users who wish to dip their feet into the {admiral} ecosystem can:

  • Learn a bit about unit testing for R packages
  • Make a meaningful contribution to {admiral}

by adding or modifying unit tests to account for lines not previously covered.

Important note: Given the above, this issue is for newcomers to {admiral} or users who wish to contribute to the package, and should not be taken on by core {admiral} developers.

Definition of Done

  • Unit test(s) added/modified to test the lines in red in get_vars_query():
    image

  • Unit test(s) added/modifiedto test the lines in red in assert_valid_queries():
    image

  • Unit test(s) added/modified to test the lines in red in assert_db_requirements():
    image

  • Unit test(s) added/modified to test the lines in red in validate_query():
    image

  • Unit test(s) added/modified to test the lines in red in basket_select():
    image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

1 participant