-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Why shouldn't I use this? #1
Comments
Sure-- so this is basically a wrapper around the request module, and that's really what you should be using. This module is fun, but it adds extra processing overhead that (afaik) doesn't really add value.
If this module just opened a TCP socket and wrote the string to that socket, then it might actually give a perf win. But you can't do that in browsers, and I'd actually be surprised if it was faster than what's in node.
Happy/interested to be proven wrong on that
… On Feb 10, 2017, at 5:27 PM, Tim Branyen ***@***.***> wrote:
Within the README you added the following:
Oh cool, should I use this?
No.
Could you explain why? I'm not as clued in and this seems like a really interesting use case for tagged template strings and learning how HTTP works w/o using a porcelain command like window.fetch.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.
|
Do you think you could just swap that out for |
Sure, if you like! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Within the README you added the following:
Could you explain why? I'm not as clued in and this seems like a really interesting use case for tagged template strings and learning how HTTP works w/o using a porcelain command like
window.fetch
.The text was updated successfully, but these errors were encountered: