Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make easy for new contributors discover and test against databases and remote filesystems #588

Open
juarezr opened this issue Jan 31, 2022 · 0 comments
Labels
Build CI CD Issues affecting github pypi readthedocs coveralls conda-forge Help Wanted We are volunteers. We'll be happy if you join us. Maintainability Issues for code modernization, improve development, testing

Comments

@juarezr
Copy link
Member

juarezr commented Jan 31, 2022

Problem description

  • Today we use tox and tox.ini for local testing
  • But testing against databases and Remote Filesystem is not easy discoverable.
  • So local testing is skipped most of the times

TODO

  • Create docker-compose / docker setup for running the needed databases and remote filesystems
  • Make it easy for the contributor set up the environment and run the tests
  • Hook it in IDE like VSCode, and others
  • Replace the hacks in the CI tests with a proper solution
  • Enable using docker testing of hard to set up formats like:

CI Test hacks

Databases

Remote Filesystems

  • This functionality needs fsspec
  • For SMB:
    • Container setup command:
      • docker run -it --name samba -p 139:139 -p 445:445 -d "dperson/samba" -p -u "petl;test" -s "public;/public-dir;yes;no;yes;all"
    • Environment variable used:
      • PETL_TEST_SMB=smb://WORKGROUP;petl:test@localhost/public/
  • For SFTP:
    • Container setup command:
      • docker run -it --name sftp -p 2244:22 -d atmoz/sftp petl:test:::public
    • Environment variable used:
      • PETL_TEST_SFTP=sftp://petl:test@localhost:2244/public/
  • For testing additional Built-in fsspec implementations:
    • Works with a similar environment variable: PETL_TEST_XXXXX
    • In conjunction with a URI understood by fspec
  • For testing additional Cloud fsspec implementations.
    • Idem.
@juarezr juarezr added Build CI CD Issues affecting github pypi readthedocs coveralls conda-forge Help Wanted We are volunteers. We'll be happy if you join us. Maintainability Issues for code modernization, improve development, testing labels Jan 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Build CI CD Issues affecting github pypi readthedocs coveralls conda-forge Help Wanted We are volunteers. We'll be happy if you join us. Maintainability Issues for code modernization, improve development, testing
Projects
None yet
Development

No branches or pull requests

1 participant