Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add isMinter function to the IERC721Minter interface #7

Open
sebastianst opened this issue Sep 3, 2021 · 0 comments
Open

Add isMinter function to the IERC721Minter interface #7

sebastianst opened this issue Sep 3, 2021 · 0 comments

Comments

@sebastianst
Copy link
Contributor

We should extend the IERC721Minter interface to

interface IERC721Minter {
    function mint(address to, uint256 id) external;
    function isMinter(address maybeMinter)  public view returns (bool);

}

so that dApps can check whether the Erdstall ERC721MinterHolder can mint on it. A dApp would just call isMinter with the holder address and it would return true if it's an ERC721Minter and the holder can mint. If the call errors, it means that the contract doesn't implement isMinter, so in particular, it's then not a ERC721Minter.

@sebastianst sebastianst modified the milestone: 21-09-17 Sep 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant