Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cache-busting of images #42

Open
scolby33 opened this issue Mar 15, 2021 · 3 comments
Open

Add cache-busting of images #42

scolby33 opened this issue Mar 15, 2021 · 3 comments

Comments

@scolby33
Copy link

I would like to be able to "cache bust" my images, that is add a fragment of a hash to the filename as a final step in the processing, sorta like mv foo.jpg foo.$(shasum foo.jpg | head -c 8).jpg. I've taken a look at the source for this plugin, and don't think it would be too difficult to add. I would be willing to make a PR for this functionality if the maintainers think it belongs here.

@S1SYPHOS
Copy link

S1SYPHOS commented Oct 3, 2022

This would be nice - I guess @MinchinWeb would agree? 😃

@MinchinWeb
Copy link
Member

Oops...this appears to have been lost for a surprisingly long time. Thank you @S1SYPHOS for bringing this to my attention.

Yes @scolby33 , (if this is still something you're interested in), a PR would be appreciated. Two things that will help me integrate your PR would be 1) a description of your usecase (this helps we understand what you're hoping the new code will do, in a practical sense), and 2) tests (to make sure I don't break the functionality later by accident). Also, feel free to post your code in a WIP state. And if you don't get a response, feel free to ping me too.

@S1SYPHOS If this is something you want to do, you're welcome to have a crack at it too.

@S1SYPHOS
Copy link

S1SYPHOS commented Oct 3, 2022

I'd have to look into your source first - but sure, I guess I could whip something up!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants