Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optional imports are imported #279

Open
2 tasks done
StijnKas opened this issue Nov 8, 2024 · 0 comments
Open
2 tasks done

Optional imports are imported #279

StijnKas opened this issue Nov 8, 2024 · 0 comments
Assignees
Labels
bug Something isn't working Python Issues related to the Python tools
Milestone

Comments

@StijnKas
Copy link
Collaborator

StijnKas commented Nov 8, 2024

pdstools version checks

  • I have checked that this issue has not already been reported.

  • I have confirmed this bug exists on the latest version of pdstools.

Issue description

In the V4 version of pdstools, we are working with optional dependencies. Today, some of these optional dependencies like httpx and requests are automatically imported when you import any module from pdstools.

Reproducible example

from pdstools import ADMDatamart

Expected behavior

Since these are optional, they should not automatically load / be imported, instead, they should only be imported when one of the relevant modules is imported directly.

Installed versions

pdstools v4
@StijnKas StijnKas added bug Something isn't working Python Issues related to the Python tools labels Nov 8, 2024
@StijnKas StijnKas added this to the V4 milestone Nov 8, 2024
@StijnKas StijnKas self-assigned this Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Python Issues related to the Python tools
Projects
None yet
Development

No branches or pull requests

1 participant