Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move 3 components to wallet-library and use in demo as an import #1

Open
johnsBeharry opened this issue Jan 24, 2019 · 3 comments
Open
Assignees

Comments

@johnsBeharry
Copy link
Member

johnsBeharry commented Jan 24, 2019

Estimate: 3h
Scenario: Break up demo-0 components and import wallet-library
  Given we have a mono-repo
  And the folder "demo-0" is a react-native app
  When I open "wallet-library/index.js"
  Then I see the components "Buttons"
  And I see "Badge" # transfer price
  And I see "Payment - List Item" # transfer list item
  And in "demo-0" I can see it imports '.../wallet-library'

Scenario: Display wallet library in a storybook
  Given I am in "wallet-library"
  When I run storybook-js
  Then I see "Buttons"
  And I see "Pill" # transfer price
  And I see "Payment - List Item" # transfer list item
@ivo-dukov
Copy link
Collaborator

@johnsBeharry the estimate for this would be 2-3 hours. @Valka7a (Valentin) is starting work now.

@johnsBeharry
Copy link
Member Author

johnsBeharry commented Jan 24, 2019

nice! I forgot to include details about styled components too -- @Valka7a if there's time please migrate the stylesheets to styled-components I fogot to spec it out.

@fre2ak going forward I'd like to keep a full issue list here for things relating to the project and have you update the descriptions with the estimates.

@ivo-dukov
Copy link
Collaborator

@johnsBeharry ok 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants