Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Usage of private API - OC_DB::updateDbFromStructure #51

Open
MorrisJobke opened this issue Mar 24, 2021 · 5 comments
Open

Usage of private API - OC_DB::updateDbFromStructure #51

MorrisJobke opened this issue Mar 24, 2021 · 5 comments

Comments

@MorrisJobke
Copy link

Hi @pbek,

we are cleaning up our code base and found that you are using a private method that we plan to remove in Nextcloud 22. It's OC_DB::updateDbFromStructure in

if ( !$this->odb->updateDbFromStructure( $structureFile ) )

Do you mind to migrate away from this method or completely copy the code over to your app so that it continues to work. The removal will happen in the PR nextcloud/server#21641

@pbek
Copy link
Owner

pbek commented Mar 25, 2021

Thank you for the heads up. Nextbackup isn't even compatible to NC21 (#50) and I'm not sure if I will put in the work to rewrite that all given that the private database API has a lot of problems as it is anyway (#35, #37, ..) 😅

@MorrisJobke
Copy link
Author

I just wanted to let you know and find possible issues easier instead of running into it and then need to find the root cause. No pressure at all from my side - it's your time and you should do what you want :)

Thanks for the app anyways, as it may help some others to accomplish a task :)

@pbek
Copy link
Owner

pbek commented Mar 25, 2021

Thank you. I still tend to trust "mysqlbackup" more when it comes to the quirks of the database... 😅 Btw. do you know if there are many users of PostgreSQL with NC (in comparison to MySQL)?

@MorrisJobke
Copy link
Author

Btw. do you know if there are many users of PostgreSQL with NC (in comparison to MySQL)?

THere are definitely a lot of them, but compared to MySQL it's the minority IMO. We don't have hard numbers over all instances because we only have opt-in surveys.

@pbek
Copy link
Owner

pbek commented Mar 25, 2021

Thank you. In the end PostgreSQL is a reliable and well trusted DBMS.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants