Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle different charsets #12

Open
nerai opened this issue Dec 23, 2017 · 2 comments
Open

Handle different charsets #12

nerai opened this issue Dec 23, 2017 · 2 comments
Labels

Comments

@nerai
Copy link
Contributor

nerai commented Dec 23, 2017

Currently, the library assumes ASCII at all times. (I hope I did not miss anything.) Out of interest, I just checked and KGS seems to store SGFs in UTF8.

It misses the CA property of the SGF standard.

Property:	CA
Propvalue:	simpletext
Propertytype:	root
Function:	Provides the used charset for SimpleText and Text type.
		Default value is 'ISO-8859-1' aka 'Latin1'.
		Only charset names (or their aliases) as specified in RFC 1345
		(or updates thereof) are allowed.
		Basically this field uses the same names as MIME messages in
		their 'charset=' field (in Content-Type).
		RFC's can be obtained via FTP from DS.INTERNIC.NET,
		NIS.NSF.NET, WUARCHIVE.WUSTL.EDU, SRC.DOC.IC.AC.UK
		or FTP.IMAG.FR.

I am currently working on this issue for another project. If I find the time I will create a PR.

@paviad paviad added the bug label Dec 23, 2017
@paviad paviad assigned paviad and unassigned paviad Dec 24, 2017
@paviad
Copy link
Owner

paviad commented Dec 24, 2017

I'd appreciate it, thanks!

@nerai
Copy link
Contributor Author

nerai commented Apr 13, 2021

To state the obvious: I've not come around to work on this and probably will not in the foreseeable future. Sorry about that. It's up for grabs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants