Upgrade pdfium #30
Open
Upgrade pdfium #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulovap
reviewed
Nov 11, 2018
| @@ -1,4 +1,4 @@ | |||
| [submodule "src/3rdparty/pdfium"] | |||
| path = src/3rdparty/pdfium | |||
| url = https://github.com/pinaraf/pdfium.git | |||
| url = https://github.com/agrogoth/pdfium.git | |||
There was a problem hiding this comment.
Hello there. Can you send a PR to paulovap/pdfium instead of point to your repo? This original change was a oversight from my part.
There was a problem hiding this comment.
Hey, this upgraded version of qtpdfium has been used on a embedded ARM device and on our Ubuntu 64-bit development machines. It works without any issues I'm aware of. Windows is untested.
I can't create a PR to paulovap/pdfium because my repository is not a fork of yours. Could you create a new branch with all changes from the official repo up to commit b7c4a02? I could then recreate my repo as a fork and put my two commits on top.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This upgrades PDFium to a recent version. Some third party libraries have been removed. System libraries are used instead. There have been API changes within PDFium which needed adapation. I've also introduced the PIMPL pattern to qtpdfium to improve binary compatibility.