Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow user to specify number of common dynamic components #11

Open
3 tasks
dbrakenhoff opened this issue Jan 12, 2023 · 0 comments
Open
3 tasks

Allow user to specify number of common dynamic components #11

dbrakenhoff opened this issue Jan 12, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@dbrakenhoff
Copy link
Member

It would be a nice feature to be able to override the automatic method to determine the number of common dynamic components.

For example:

import metran as mt

ml = mt.Metran(oseries, nfactors=2)
ml.solve()

Currently the FactorAnalysis class also contains a maxfactors argument that can presumably be used to limit the no. of factors. This is not exposed through the Metran model class however. So perhaps we should also expose this argument in the Metran class?

Additionally it would be nice to test the current implementation for estimating the number of factors on a dataset that results in 2 (or more) common components.

So in short:

  • Allow manual setting for number of factors
  • Expose maxfactors keyword argument in FactorAnalysis (if this makes sense)
  • Test metran with dataset that results in 2+ common dynamic components
@martinvonk martinvonk added the enhancement New feature or request label Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants