Added support for http client configuration via command arguments #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
speatzle
reviewed
Nov 30, 2024
| @@ -60,6 +60,10 @@ func init() { | |||
| rootCmd.PersistentFlags().Uint("mfaRetrys", 3, "How often to retry TOTP Auth, only used in nointeractive modes") | |||
| rootCmd.PersistentFlags().Duration("mfaDelay", time.Second*10, "Delay between MFA Attempts, only used in noninteractive modes") | |||
|
|
|||
| rootCmd.PersistentFlags().Bool("tlsSkipVerify", false, "Allow servers with self-signed certificates") | |||
| rootCmd.PersistentFlags().String("tlsClientPrivateKey", "", "Client private key for mtls") | |||
| rootCmd.PersistentFlags().String("tlsClientCert", "", "Client certificate for mtls") | |||
There was a problem hiding this comment.
We probably should allow importing the Certificate and Key from a File Path like we do for userPrivateKeyFile.
| if !certExists && keyExists { | ||
| return tls.Certificate{}, fmt.Errorf("Client TLS cert is empty, but client TLS private key was sent.") | ||
| } | ||
| return tls.LoadX509KeyPair("client.cert", "client-key.pem") |
There was a problem hiding this comment.
This always loads the key Pair from these Hardcoded Files instead of from the Flag?
| return tls.Certificate{}, nil | ||
| } | ||
| if certExists && !keyExists { | ||
| return tls.Certificate{}, fmt.Errorf("Client TLS private key is empty, but client TLS cert was sent.") |
There was a problem hiding this comment.
Did you mean set instead of sent?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for some http client configurations. It adds support to:
disable the tls server certificate verification with '--tlsSkipVerify' argument
attach a client certificate on http request