Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clipToStartTime: false does not work #30

Open
VE3NEA opened this issue Jul 4, 2024 · 0 comments
Open

clipToStartTime: false does not work #30

VE3NEA opened this issue Jul 4, 2024 · 0 comments

Comments

@VE3NEA
Copy link

VE3NEA commented Jul 4, 2024

The clipToStartTime: false parameter of GroundStation.Observe does not work, because the last term in the condition to walk back always evaluates to false:

if (!clipToStartTime && obs.Count > 0 && obs[0].Start == start)

This happens because obs[0].Start, computed in FindCrossingTimeWithinInterval, is between start-deltaTime and start, not exactly equal to start.

Suggested solution: replace == with <= in the if statement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant