WIP: Add OpenPMD support #1050
Open
WIP: Add OpenPMD support #1050
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pgrete
commented
Apr 12, 2024
src/outputs/openpmd.cpp
Outdated
Comment on lines
272
to
275
| for (auto &pmb : pm->block_list) { | ||
| // TODO(pgrete) check if we should skip the suffix for level 0 | ||
| const auto level = pmb->loc.level() - pm->GetRootLevel(); | ||
| const std::string &mesh_record_name = var_name + "_lvl" + std::to_string(level); |
pgrete
commented
Apr 12, 2024
src/outputs/restart_opmd.cpp
Outdated
Comment on lines
120
to
125
| for (auto &pmb : pm->block_list) { | ||
| // TODO(pgrete) check if we should skip the suffix for level 0 | ||
| // TODO(pgrete) ask LR why this is not mirrored from writing | ||
| // const auto level = pmb->loc.level() - pm->GetRootLevel(); | ||
| const auto level = pmb->loc.level(); | ||
| const std::string &mesh_record_name = var_name + "_lvl" + std::to_string(level); |
|
Another alternative would be to create a "mesh" called "Params" and one "record" per package that could carry all the attribute (or sth along those directions), but again, I would consider that a work around rather than a clean use of the intended standard. |
|
Ok, that makes sense, but I think there's a risk this will be significantly delayed if this is blocked on a > 1 yr old PR in openPMD. |
|
I am unable to read the outputs this produces with Paraview. Has anyone else been able to do so? Details: https://discourse.paraview.org/t/no-fields-are-rendered-after-opening-openpmd-file/15533 |
In case anyone else encounters this, the files load fine using the ADIOS2 image reader in Paraview, but not with the OpenPMD-api reader: https://openpmd-api.readthedocs.io/en/latest/analysis/paraview.html#openpmd |
|
This PR is now broken due to changes in #1177: @Yurlungur is there an easy fix for this? |
Yes, I'll take care of it. |
|
Done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
PR Checklist