Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Global logdir option does nothing #21612

Open
huonw opened this issue Nov 4, 2024 · 0 comments
Open

Global logdir option does nothing #21612

huonw opened this issue Nov 4, 2024 · 0 comments
Labels

Comments

@huonw
Copy link
Contributor

huonw commented Nov 4, 2024

Describe the bug

Currently (fdfd8d2), the logdir global option doesn't seem to be read by any code. https://github.com/search?q=repo%3Apantsbuild%2Fpants%20logdir&type=code

(NB. there's a separate [workunit-logger].logdir option that is read)

This suggests either:

  • there's a bug where the option should be used for something, but isn't
  • the option can be deprecated and removed

As yet unclear which.

(Presumably this was used in the past/when it was added, so some git log -S (or similar) delving might be good.)

Pants version

fdfd8d2

OS
N/A

Additional info

Noticed in:

Referenced in:

@huonw huonw added the bug label Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant