-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FCM API has been deprecated for removal June 2024 #32
Comments
@panicbit this needs to be addressed, but I think you've got too much on your plate. This library hasn't been updated in a year. I'd be happy to take over maintenance, can we discuss that? We need this library at my company. You can reach me here and privately at dan [at] upduo.com |
@adnanjpg Could you perhaps already create that PR, or share some code which implements this? |
@rj76 sure, I'll share an example code here by the weekend, opening a pr will take a while though as im a bit busy these few weeks |
@adnanjpg thank you so much :) maybe I can put together a PR if time allows |
@rj76 here you go. please follow the instructions written in the |
@eloff I think it's best for you to open an issue about taking over the maintenance, if there's still no response then you can invite contributors to your fork |
@rj76 hi, i had been working on this for the past hour and i was about to finish too, seems like we should've coordinated better anyway, assuming you've made more progress on this than i have, im going to pause my work and wait for you if you need any help, please don't hesitate to mention me |
@adnanjpg Would you like to review and possibly test? |
@rj76 hi, the work you've done looks fantastic, there's just some tiny mistakes & refactors, and also there's some errors. I will be opening a pr on your repo with the fixes I've put & open issues with the concerns I have |
if everything was good i made i would be worried 😁 thanks in advance for your time and feedback |
@rj76 hi, in case you have not noticed I had submitted a pr yesterday on your repo. happy new year |
The API endpoint being used has been deprecated and will be removed in June 2024.
The text was updated successfully, but these errors were encountered: