Dockerfile for grounder.

[rpgoldman]

No description provided.

[rpgoldman]

I have marked this as a WIP because to run it I have been also using a script file that I believe to be poorly designed.

[rpgoldman]

Also, if I knew more about GitHub actions, I would suggest setting up a GitHub action that would automatically build the Docker image.

[galvusdamor]

True! That is something, I could try to figure out at some point :)

[rpgoldman]

For simple cases like this, there is a sample GitHub action, which I have attempted to insert into the branch. Not sure if it will run -- may need to extend the on: part to make it testable.

[rpgoldman]

I'm not sure how to test the GitHub action -- I added the workflow_dispatch setting, which should allow the workflow to be manually triggered for testing. But... according to the docs, you can only manually trigger workflows that are on the main branch (in our case master).

[galvusdamor]

For your copy there is really no reason to keep the changes in a separate branch (as we still have the panda-planner-dev:master as the overall true master). If you merge the dockerfile branch into your master, you can still PR your master into this one and try to test-run the dockerfile in your repo.

[rpgoldman]

I have the dockerfile working again. I don't like the need to apply the patch, though, because it means that if I run docker build in a directory in which the patch has already been applied, then the build will fail.

That's why the Dockerfile now makes sure that cpddl is clean and then applies the patch.

This is very kludgy and will fail as soon as the patch becomes no longer necessary.

It would be much better to fork the cpddl repo, apply the patch to the fork, and use the fork for the external, instead of using upstream as the external and having to patch it. Doing so makes the build process ugly and brittle.