Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use github service containers in CI #37

Open
northernSage opened this issue Jun 1, 2021 · 0 comments
Open

Use github service containers in CI #37

northernSage opened this issue Jun 1, 2021 · 0 comments
Labels
tests Related to test suite or testing infrastructure

Comments

@northernSage
Copy link
Member

northernSage commented Jun 1, 2021

Following #35, using service containers as an alternative to manually installing chachelib external dependencies in tests.yml workflow (e.g. memcached, redis, pylibmc headers) seems like an interesting option.

Some thoughts:

  • Two separate services will be necessary one for redis and one for memcached.
  • The pytext-xprocess fixtures should not start local instances of redis and memcached when running under CI since the containers will be up. One way of going about this is checking one of the many environment variables set by the CI and having xprocess start (or not) based on the result.
  • The github macOS does not have docker installed by default, so it will need to be set up.
@northernSage northernSage added the tests Related to test suite or testing infrastructure label Jun 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests Related to test suite or testing infrastructure
Development

No branches or pull requests

1 participant