Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix string-to-long coercion when afterburner is enabled #1832

Merged
merged 2 commits into from
Dec 2, 2020

Conversation

carterkozak
Copy link
Contributor

Reported upstream:
FasterXML/jackson-modules-base#120

Before this PR

The CoercionConfig is fantastic, unfortunately it is not yet
supported by the AfterBurner module. Separately we may consider
moving to the new Blackbird module on java 11 runtimes.

For now I've updated our existing long deserializers for 2.12.0
which has the benefit of rejecting coercion from string to SafeLong.

After this PR

==COMMIT_MSG==
Fix string-to-long coercion when afterburner is enabled
==COMMIT_MSG==

Reported upstream:
FasterXML/jackson-modules-base#120

The CoercionConfig is fantastic, unfortunately it is not yet
supported by the AfterBurner module. Separately we may consider
moving to the new Blackbird module on java 11 runtimes.

For now I've updated our existing long deserializers for 2.12.0
which has the benefit of rejecting coercion from string to SafeLong.
@changelog-app
Copy link

changelog-app bot commented Dec 2, 2020

Generate changelog in changelog/@unreleased

Type

  • Feature
  • Improvement
  • Fix
  • Break
  • Deprecation
  • Manual task
  • Migration

Description

Fix string-to-long coercion when afterburner is enabled

Check the box to generate changelog(s)

  • Generate changelog entry

@policy-bot policy-bot bot requested a review from CRogers December 2, 2020 15:16
@ferozco
Copy link
Contributor

ferozco commented Dec 2, 2020

👍

@bulldozer-bot bulldozer-bot bot merged commit 4669b5d into develop Dec 2, 2020
@bulldozer-bot bulldozer-bot bot deleted the ckozak/string_to_long_coercion_afterberner branch December 2, 2020 16:26
@svc-autorelease
Copy link
Collaborator

Released 6.9.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants