New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider making Crystal.cell_volume() a @property #289

Open

ajjackson opened this issue Sep 6, 2023 · 0 comments

Milestone

Collaborator

ajjackson commented Sep 6, 2023

Suggested by @oerc0122 in #288 review

Things would look a little cleaner if this was accessed as a property, and it would be nice if the result was cached.

It's a breaking change though, so should be deferred until v2 if it happens at all.

ajjackson added this to the v2.0 milestone

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment