Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Get Track Details #15

Open
p5quared opened this issue Jul 25, 2024 · 4 comments
Open

Feature: Get Track Details #15

p5quared opened this issue Jul 25, 2024 · 4 comments
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@p5quared
Copy link
Owner

From conversation on #13.

Need to decide what details? Guess it doesn't matter we can always add more.

2 options:

  1. Individual functions (get_track_artist(), get_track_album()...).
  2. get_track_info() -> detailsTable

I kind of like 2. more. Thoughts?

@p5quared p5quared added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers labels Jul 25, 2024
@p5quared
Copy link
Owner Author

I think for now getting the info of the currently playing track is plenty good enough. If someone wants we could add get_track_details(trackname)

@ducktordanny
Copy link
Contributor

Yeah, I think the 2. option would give more flexibility to the users. And we wouldn't have to create X function to access X type of details.

@p5quared
Copy link
Owner Author

Exactly, we just add fields to the table. We'll just need to be clear that the table fields may be extended between releases so people shouldn't iterate over it.

@p5quared
Copy link
Owner Author

We could start with

  1. Track Name
  2. Track Artist
  3. Track Album

And expand if anyone wants.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants