Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UI] Area for displaying params should be hidden when not populated #1570

Open
samamou opened this issue Sep 12, 2024 · 1 comment
Open

[UI] Area for displaying params should be hidden when not populated #1570

samamou opened this issue Sep 12, 2024 · 1 comment
Assignees

Comments

@samamou
Copy link
Contributor

samamou commented Sep 12, 2024

This parameter panel, responsible for displaying params, as per the docs, if i understand correctly, is always shown, even when it's empty and has no data to display.

Expected behavior

Screenshot from 2024-09-12 16-04-01

Current (unexpected) behavior

where this space is empty (and should be hidden)

  1. When on any other tab, other than # 1 (Device Explorer)
    image
    Screenshot from 2024-09-12 16-03-37
  2. When user hasn't selected an address/device, yet.
    Screenshot from 2024-09-12 16-03-50
    Screenshot from 2024-09-12 16-04-20

Suggested fix:

easier said than done.. but does this make sense?

panel->hide();  // When there is no data / nothing is selected
panel->show();  // When there is data to display? onSelection()
@samamou samamou self-assigned this Sep 12, 2024
@github-project-automation github-project-automation bot moved this to TODO in UI Sep 12, 2024
@samamou
Copy link
Contributor Author

samamou commented Sep 12, 2024

starting to look at .ossia/score/src/plugins/score-plugin-deviceexplorer/Explorer/Explorer/AddressItemModel.cpp is this the right place to look? @jcelerier

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: TODO
Status: TODO
Development

No branches or pull requests

2 participants