🌱 Fix lint issues: wrapcheck linter #446
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumping version of golangci-lint because it has a fix for a false positive we were encountering.
ristomcgehee
commented
May 13, 2021
| @@ -45,7 +45,7 @@ test: ## Runs unit test | |||
| go test -covermode atomic `go list ./... | grep -v e2e` | |||
|
|
|||
| golangci-lint: | |||
| go install github.com/golangci/golangci-lint/cmd/golangci-lint@v1.39.0 | |||
| go install github.com/golangci/golangci-lint/cmd/golangci-lint@v1.40.0 | |||
There was a problem hiding this comment.
Bumping the version because 1.40.0 contains a fix for when the wrapcheck linter was flagging errors.Wrap() as needing wrapping (see issue).
naveensrinivasan
approved these changes
May 13, 2021
|
Thank you for the contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Code quality improvement
What is the current behavior? (You can also link to an open issue here)
This PR fixes issues from the wrapcheck linter (checks that errors returned from external packages are wrapped).
Part of issue #173.
What is the new behavior (if this is a feature change)?
n/a
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
No