Skip to content
This repository has been archived by the owner on Nov 3, 2023. It is now read-only.

Impact of encoding/xml vulns #127

Open
licaon-kter opened this issue Dec 15, 2020 · 4 comments
Open

Impact of encoding/xml vulns #127

licaon-kter opened this issue Dec 15, 2020 · 4 comments

Comments

@licaon-kter
Copy link

Ref: https://mattermost.com/blog/coordinated-disclosure-go-xml-vulnerabilities/

@ortuman
Copy link
Owner

ortuman commented Sep 10, 2021

Sorry, but I think I'm missing some context here. How these vulnerabilities are supposed to affect the project?

@licaon-kter
Copy link
Author

It affects go stuff that processes xml, jackal does this, maybe it's too.

It's more a heads-up, you'd need to analyze if your useage is impacted or not.

@PaluMacil
Copy link

If there is no security concern related to the ordering of attributes and elements, I don't believe these types of vulnerabilities affect the project. Basically, there is no way to ensure deterministic ordering between a struct and xml doc through round trips. There are third party libraries which may be discussed in that blog post, if I recall, which can help this, but my guess is that this is not necessary unless you have some of the same concerns as projects like SAML which I believe is where this was identified as an issue.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants