Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

volcartesian: properly update patch data structures when switching memory mode #475

Merged
merged 2 commits into from
Jul 1, 2024
Merged

volcartesian: properly update patch data structures when switching memory mode #475

merged 2 commits into from
Jul 1, 2024

Conversation

andrea-iob
Copy link
Member

After switching to normal memory mode, we need to update the patch to make sure all data structures (e.g. interfaces) are properly updated.

@andrea-iob andrea-iob self-assigned this Jun 21, 2024
ksamouchos
ksamouchos approved these changes Jun 25, 2024
View reviewed changes
Copy link
Contributor

@ksamouchos ksamouchos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with the changes. I tested it and I don't see the error anymore.

@andrea-iob andrea-iob merged commit b27524e into master Jul 1, 2024
10 checks passed
@andrea-iob andrea-iob deleted the volocartesian.fix.normal.memory.mode branch July 1, 2024 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ksamouchos ksamouchos ksamouchos approved these changes

Assignees

@andrea-iob andrea-iob

Labels
bug M - volcartesian
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andrea-iob @ksamouchos