[59539] Migrate scheduling mode and lags #17235
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbliard
force-pushed
the
feature/42388-new-automatic-scheduling-mode
branch
from
3b388c0
to
ccbaae4
Compare
https://community.openproject.org/wp/42388 Scheduling mode is now manual by default. Only successors will be in automatic mode. WIP
cbliard
force-pushed
the
feature/42388-new-automatic-scheduling-mode
branch
from
ccbaae4
to
30d07e7
Compare
More expressive code.
To preserve dates, a lag is set for follows relations when both the predecessor and the follower have dates.
`lag` is the number of _working_ days between predecessor and successor dates.
The rule is: it never switches from manual to automatic scheduling mode. It only switches from automatic to manual, and only if keeping automatic is not possible because it would mean losing the dates. The code and specs have been updated to reflect this. A materialized view is used to reuse the data in multiple different queries.
cbliard
force-pushed
the
feature/42388-new-automatic-scheduling-mode
branch
from
46a22d1
to
391d65b
Compare
cbliard
changed the title
The column is also non-nullable now.
The tests have to be adapted to explicitly set scheduling mode to automatic for followers (which used to be the default). Also, add a new column type for days counting in the table helpers. It controls the `ignore_non_working_days` attribute
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
https://community.openproject.org/wp/59539
(Part of https://community.openproject.org/wp/42388)
What are you trying to accomplish?
Implement new automatic scheduling mode
Migration:
Feature implementation:
Screenshots
TBD
What approach did you choose and why?
TBD
Merge checklist