-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(platform): gencode should generate js and d.ts files #292
Conversation
jakedoublev
commented
May 22, 2024
•
edited
Loading
edited
- updates platform proto gencode file extensions
- improves proto generation shell script to clean the gencode directory when running
If these changes look good, signoff on them with:
If they aren't any good, please remove them with:
|
ae358e2
to
e81aa5e
Compare
If these changes look good, signoff on them with:
If they aren't any good, please remove them with:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've filed an issue about some more automation I'd like to see
#293
In support of actually releasing this.
16d059d
8f4c8a3
to
16d059d
Compare
If these changes look good, signoff on them with:
If they aren't any good, please remove them with:
|
be3e454
to
e75afb8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just one dependency I don't think you need to install in the platform.sh script
Quality Gate passedIssues Measures |