Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(platform): gencode should generate js and d.ts files #292

Merged
merged 5 commits into from
May 29, 2024

Conversation

jakedoublev
Copy link
Contributor

@jakedoublev jakedoublev commented May 22, 2024

  • updates platform proto gencode file extensions
  • improves proto generation shell script to clean the gencode directory when running

@jakedoublev jakedoublev requested a review from a team as a code owner May 22, 2024 22:06
Copy link

If these changes look good, signoff on them with:

git pull && git commit --amend --signoff && git push --force-with-lease origin

If they aren't any good, please remove them with:

git pull && git reset --hard HEAD~1 && git push --force-with-lease origin

Copy link

If these changes look good, signoff on them with:

git pull && git commit --amend --signoff && git push --force-with-lease origin

If they aren't any good, please remove them with:

git pull && git reset --hard HEAD~1 && git push --force-with-lease origin

Copy link
Member

@dmihalcik-virtru dmihalcik-virtru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've filed an issue about some more automation I'd like to see
#293

In support of actually releasing this.

pbacon-blaber
pbacon-blaber previously approved these changes May 23, 2024
Copy link

If these changes look good, signoff on them with:

git pull && git commit --amend --signoff && git push --force-with-lease origin

If they aren't any good, please remove them with:

git pull && git reset --hard HEAD~1 && git push --force-with-lease origin

jrschumacher
jrschumacher previously approved these changes May 23, 2024
jrschumacher
jrschumacher previously approved these changes May 28, 2024
ryanulit
ryanulit previously approved these changes May 29, 2024
Copy link

@ryanulit ryanulit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one dependency I don't think you need to install in the platform.sh script

scripts/platform.sh Outdated Show resolved Hide resolved
Copy link

sonarcloud bot commented May 29, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@jakedoublev jakedoublev merged commit cc32059 into main May 29, 2024
11 checks passed
@jakedoublev jakedoublev deleted the chore/platform-gencode branch May 29, 2024 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants