Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Policy: Employ db transactions for Policy object Update operations #1786

Open
ryanulit opened this issue Nov 25, 2024 · 0 comments
Open

Policy: Employ db transactions for Policy object Update operations #1786

ryanulit opened this issue Nov 25, 2024 · 0 comments

Comments

@ryanulit
Copy link
Contributor

ryanulit commented Nov 25, 2024

Background

DB transactions support will be officially introduced once PR #1778 is merged. After the merge, we should continue to improve the safety of our DB interactions by employing transactions for existing Update operations that require multiple DB calls for auditing purposes or ACID guarantees.

These should include:

  • Safe Update and Deactivation methods
  • Unsafe Reactivation methods

Acceptance Criteria

  • Transactions used appropriately by methods mentioned above
  • Integration tests continue to pass
  • No additional integration tests should be necessary, as there is already test coverage for the method providing transactions support
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant