You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When the policy service was developed, we made the choice to have the upsert FQN function to act as a side-effect so that we could continue moving quickly. This was not a concern since the fqn reindex was relatively liteweight and could be run at any time.
The code has changed slightly since this ticket was created. The upsertAttrFqn was removed in PR #1679 with added batching support and usage of the SQLC queries directly. An AttrFqnReindex method remains, but it is only used by a CLI method and the integration testing framework. This PR will add transaction support to the gRPC service method calls using the SQLC upsert... methods directly, as well as the CLI command using AttrFqnReindex.
When the policy service was developed, we made the choice to have the upsert FQN function to act as a side-effect so that we could continue moving quickly. This was not a concern since the fqn reindex was relatively liteweight and could be run at any time.
platform/service/policy/db/attribute_fqn.go
Lines 22 to 31 in c486712
Since we are introducing transactions with SQLC we should shift this functionality to a transaction to ensure consistency and monitoring.
Acceptance Criteria
The text was updated successfully, but these errors were encountered: