Custom layer filters #5347
Open
Custom layer filters #5347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nenad-vujicic
approved these changes
Nov 21, 2024
AntonKhorev
force-pushed
the
custom-layer-filters
branch
from
c47522c
to
88e0ee7
Compare
AntonKhorev
force-pushed
the
custom-layer-filters
branch
from
88e0ee7
to
8e359a8
Compare
|
I don't approve of this PR, because I believe the cartographers, not the developers, should choose what their "dark mode maps" look like. See #5328 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Applies different filters in dark mode: invert+rotate for layers without hillshading, dim for layers with.
Doesn't implement any controls to changing the filter and, consequently, doesn't store selected values. For storing I'd start with deciding if #5339 is ok first.