From bf58aa1c23b88ea5138810dba660d5d6f839c11d Mon Sep 17 00:00:00 2001 From: Roy Johnson Date: Wed, 21 Aug 2024 12:49:17 -0500 Subject: [PATCH] Make highlight Actions menu items (Edit and Delete) buttons [DISCO-307] For clarity, changed `ol` to `menu` Also simplified return value of DropdownItem. --- src/app/components/Dropdown.tsx | 1 - src/app/components/__snapshots__/DotMenu.spec.tsx.snap | 2 -- src/app/components/__snapshots__/Dropdown.spec.tsx.snap | 2 -- .../SummaryPopup/__snapshots__/ContextMenu.spec.tsx.snap | 1 - 4 files changed, 6 deletions(-) diff --git a/src/app/components/Dropdown.tsx b/src/app/components/Dropdown.tsx index e26a59415f..7266b6e916 100644 --- a/src/app/components/Dropdown.tsx +++ b/src/app/components/Dropdown.tsx @@ -257,7 +257,6 @@ return tabIndex={0} onClick={onClick} target={target} - onMouseEnter={focusMe} {...analyticsDataProps} >{prefix}{msg} // Safari support tab-navigation of buttons; this operates with space or Enter diff --git a/src/app/components/__snapshots__/DotMenu.spec.tsx.snap b/src/app/components/__snapshots__/DotMenu.spec.tsx.snap index f6da4f2c26..ba915b9822 100644 --- a/src/app/components/__snapshots__/DotMenu.spec.tsx.snap +++ b/src/app/components/__snapshots__/DotMenu.spec.tsx.snap @@ -240,7 +240,6 @@ exports[`Dropdown matches snapshot 1`] = ` @@ -516,7 +515,6 @@ exports[`Dropdown matches snapshot on right align 1`] = ` diff --git a/src/app/components/__snapshots__/Dropdown.spec.tsx.snap b/src/app/components/__snapshots__/Dropdown.spec.tsx.snap index 4f3dd5a0b1..bb1943b9c6 100644 --- a/src/app/components/__snapshots__/Dropdown.spec.tsx.snap +++ b/src/app/components/__snapshots__/Dropdown.spec.tsx.snap @@ -171,7 +171,6 @@ exports[`Dropdown matches snapshot 1`] = ` @@ -479,7 +478,6 @@ exports[`Dropdown matches snapshot for tab hidden (open) 1`] = ` diff --git a/src/app/content/highlights/components/SummaryPopup/__snapshots__/ContextMenu.spec.tsx.snap b/src/app/content/highlights/components/SummaryPopup/__snapshots__/ContextMenu.spec.tsx.snap index 6f9d5fc110..be1cb63f32 100644 --- a/src/app/content/highlights/components/SummaryPopup/__snapshots__/ContextMenu.spec.tsx.snap +++ b/src/app/content/highlights/components/SummaryPopup/__snapshots__/ContextMenu.spec.tsx.snap @@ -1026,7 +1026,6 @@ exports[`ContextMenu match snapshot when open 1`] = `