Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kuttl test to cover an edge deployment scenario #495

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

fmount
Copy link
Contributor

@fmount fmount commented Mar 29, 2024

This patch introduces a kuttl test that is supposed to cover an Edge use case deployment. It asserts that the required resources exist and the Pods are available. This change also updates the Edge sample to make sure it reflects the right type.

@fmount fmount requested a review from konan-abhi March 29, 2024 14:25
@openshift-ci openshift-ci bot requested review from abays and dprince March 29, 2024 14:25
Copy link
Contributor

openshift-ci bot commented Mar 29, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fmount

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@fmount
Copy link
Contributor Author

fmount commented Mar 29, 2024

The failure is expected until #494 lands.

  [FAILED] Unexpected error:
      <*errors.StatusError | 0xc0007306e0>:
      admission webhook "vglance.kb.io" denied the request: Invalid backend configuration detected
      {
          ErrStatus: {
              TypeMeta: {Kind: "Status", APIVersion: "v1"},
              ListMeta: {
                  SelfLink: "",
                  ResourceVersion: "",
                  Continue: "",
                  RemainingItemCount: nil,
              },
              Status: "Failure",
              Message: "admission webhook \"vglance.kb.io\" denied the request: Invalid backend configuration detected",
              Reason: "Forbidden",
              Details: nil,
              Code: 403,
          },
      }

@fmount
Copy link
Contributor Author

fmount commented Mar 29, 2024

For the same reason, kuttl is failing and it should pass after rebasing on top of #494

=== CONT  kuttl/harness/glance_edge
    logger.go:42: 15:07:49 | glance_edge | Skipping creation of user-supplied namespace: glance-kuttl-tests
    logger.go:42: 15:07:49 | glance_edge/1-deploy_glance | starting test step 1-deploy_glance
    logger.go:42: 15:07:49 | glance_edge/1-deploy_glance | running command: [sh -c oc kustomize ../../../../config/samples/layout/edge | oc apply -n $NAMESPACE -f -
        ]
    logger.go:42: 15:07:51 | glance_edge/1-deploy_glance | Error from server (Forbidden): error when creating "STDIN": admission webhook "vglance.kb.io" denied the request: Invalid backend configuration detected
    case.go:364: failed in step 1-deploy_glance
    case.go:366: exit status 1

@fmount fmount marked this pull request as draft March 29, 2024 15:44
@fmount fmount marked this pull request as ready for review April 2, 2024 07:05
@openshift-ci openshift-ci bot requested a review from olliewalsh April 2, 2024 07:05
@fmount fmount force-pushed the edge_kuttl branch 2 times, most recently from 6c44626 to 82d7669 Compare April 2, 2024 07:39
This patch introduces a kuttl test that is supposed to cover an Edge use
case deployment. It asserts that the required resources exist and the
Pods are available. This change also updates the Edge sample to make
sure it reflects the right type.

Signed-off-by: Francesco Pantano <fpantano@redhat.com>
@fmount fmount force-pushed the edge_kuttl branch 2 times, most recently from efdf1aa to c54d3e7 Compare April 3, 2024 07:32
@fmount fmount marked this pull request as draft April 3, 2024 08:29
@fmount fmount marked this pull request as ready for review April 3, 2024 08:29
default:
customServiceConfig: |
[DEFAULT]
enabled_backends=default_backend:rbd,az1:rbd,az2:rbd
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have to review the samples config because this is not going to work w/o a ceph Pod deployed by in the kuttl context

@fmount
Copy link
Contributor Author

fmount commented Apr 24, 2024

/retest

Copy link
Contributor

openshift-ci bot commented Apr 24, 2024

@fmount: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/glance-operator-build-deploy-kuttl c54d3e7 link true /test glance-operator-build-deploy-kuttl

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants